(Bug report) Keyboard shortcuts in tree context menu are not in line with menu item

[meichthys]

Description

The keyboard shortcut seems to be a few pixels higher than the menu items in the tree context menu:

If i remove the padding-top formatting it seems to fix it:

TriliumNext Version

0.90.12

What operating system are you using?

Windows

What is your setup?

Local (no sync)

Operating System Version

Windows 11

Error logs

No response

[pano9000]

seems to be only present in the "legacy" styles, the new TriliumNext styles do not have this bug.
I'll submit a fix for these

edit: after looking at the CSS it seems to be also present in the new ones as well, but it's not as noticeable.

there is one comment in the styles.css file, that I need to do some research first though:

.dropdown-menu kbd {
float: right;
color: var(--muted-text-color);
border: none;
background-color: transparent;
box-shadow: none;
/* 0 padding needed otherwise this increases the size of dropdown after dynamic positioning (which is then screwed) */
padding-top: 0;
padding-bottom: 0;
}

will check this weekend :-)

[eliandoran]

@pano9000 , as long as the height of a single menu item does not increase after adjusting the padding you should be OK.

[pano9000]

similar issue, slightly different exact cause
#5399

I would propose switching to a Flexbox or Grid based layout for the context menu, instead of a "block" based one
@eliandoran would a change like that be OK, or would it be causing issues with existing Themes (especially third party ones)?
Not fully sure how the whole "theme" topic is realized here.

[eliandoran]

@pano9000 , indeed flexbox seems to be a good way to go.