Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable writing ETC2 #47

Merged
merged 2 commits into from
May 10, 2024
Merged

Enable writing ETC2 #47

merged 2 commits into from
May 10, 2024

Conversation

Trimatix
Copy link
Owner

Notes for reviewer:

  • there's no immediately obvious ETC2 codec to use, except for etcpak. etcpak's ETC2 compression function returns almost completely black images, it doesn't seem to be working properly.
    This PR is a stopgap solution - ETC2 is backwards compatible with ETC1, so for now we can just compress with ETC1.
    AEIs compressed in this way are opening as expected using tex2img.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/AEPi
   codec.py37392%22, 40, 119
   constants.py84792%38–44, 64, 70
   exceptions.py401172%18–19, 28–29, 39–40, 47, 54, 61, 68–69
src/AEPi/codecs
   EtcPakCodec.py301647%12–13, 24–38, 43–49
   RawCodec.py13285%15, 20
   Tex2ImgCodec.py24579%12–13, 32, 38–39
   __init__.py8275%11–12
src/AEPi/image
   AEI.py2412789%121, 181, 185, 198, 225, 288, 294–297, 302, 326, 333, 341–342, 347–351, 382, 396–397, 436–437, 444–445, 488–489
   texture.py19289%29, 49
src/AEPi/lib
   binaryio.py24196%64
   imageOps.py9278%13–14
src/tests/image
   test_AEI.py199199%29
TOTAL8507991% 

Tests Skipped Failures Errors Time
43 0 💤 0 ❌ 0 🔥 0.349s ⏱️

@Trimatix Trimatix merged commit 4e82648 into dev May 10, 2024
1 check passed
@Trimatix Trimatix deleted the etc2-writeas-etc1 branch May 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant