Add support for command args with JSON Array #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justenwalker
force-pushed
the
array-args
branch
2 times, most recently
from
cf18933
to
5b5b1c3
Compare
- Refactor getCmd into argsToCmd and strToCmd - Add *Cmd parameters to all config structs - Add parseCommandArgs function which supports JSON array or JSON string - Do parsing of all commands once - during loadConfig() - Update README
justenwalker
force-pushed
the
array-args
branch
from
9e4160a
to
bd9ef3e
Compare
| } | ||
| } | ||
|
|
||
| func getCmd(args []string) *exec.Cmd { | ||
| func argsToCmd(args []string) *exec.Cmd { |
There was a problem hiding this comment.
I feel like argsToCmd and strToCmd should be moved into config.go now, just because all but one of their callers are in config.go.
|
I like the approach here. Just a few comments to fix I think. |
- If JSON is not provided, return an empty string form parseInterfaces to prevent future null-ref problems
- Convert errors.New(fmt.Sprintf()) into fmt.Errorf() - Break up long lines using the former convention
|
@tgross I agree with and have addressed your comments. |
|
LGTM! Merging! |
tgross
added a commit
that referenced
this pull request
Dec 9, 2015
Add support for command args with JSON Array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README.md for a better description
For #37