Feature/adhithya christen/firebase auth, sign up routes #40

christen03 · 2023-02-11T08:08:04Z

Tracking Info

Resolves #27

Make sure your branch name conforms to: <feature|staging|bugfix|...>/<username>/<3-4 word description separated by dashes>. Otherwise, please rename your branch and create a new PR.

Changes

We implemented POST routes for both mentee and mentor with error handling. We also connected our routes to Firebase, so for every user created, Firebase will also store their data along with a personal access token.

Testing

We ran test requests to Postman and checked to ensure the data was actually being posted on MongoDB, which it was.

Confirmation of Change

Validation functions for routes can be found in the middleware folder validation.ts
Error handling changes can be found in the errors folder, errors.ts, validationError.ts.
Firebase connections can be found in the services folder, auth.ts, firebase.ts
Routes can be found in the routes folder, routes.ts
Updated mentee/mentor document models can be found in models, mentee.ts, mentor.ts

…b.com/TritonSE/ALUM-Mobile-Application into feature/AdhithyaChristen/FirebaseAuth Adding mentor.ts to models

…b.com/TritonSE/ALUM-Mobile-Application into feature/AdhithyaChristen/FirebaseAuth "Adding route files"

…r bad strings/duplicated email

adhi0331

The route works for me properly. The error checking messages and mentor/mentee schema will need to be updated, but the route is good to be used for developing the sign-up flow on front-end.

adhi0331 · 2023-02-14T00:13:35Z

backend/src/config.ts

+ * Have to do this workaround since lint doesn't let
+ * us export vars
+ */
+const port = portV;


I had to add this thing to work around the linting error. Not an important issue right now but if there is a better workaround this, that would be nice because it is a bit messy.

Gotcha! Note to resolve this in the clean backend setup task we will make

adhi0331 · 2023-02-14T00:15:02Z

backend/src/models/mentor.ts

+  build(attr: MentorInterface): MentorDoc;
+}
+
+const mentorSchema = new mongoose.Schema({


After looking at Figma I realize that we need to update mentor and mentee schema to store additional values (images, major, interests, etc.). Not important now but it will be updated in future PR's.

It is kinda important so that the the frontend can be properly integrated with the Signup flow. Since this shouldn't take too long, can we add the fields?

to be resolved - #46

HarshGurnani

All looks good to me, there still seems to be lint errors in user.ts but if those console messages are supposed to be present then everything is good!

AmanKAggarwal

Great work setting up all the auth stuff! Left some comments on finishing up the sign-up route but other than that looks good. Please ping on slack when you address the changes so that I can approve

AmanKAggarwal · 2023-02-15T19:26:04Z

ALUM/ALUM.xcodeproj/project.pbxproj

@@ -68,6 +68,7 @@
 			);
 			path = ALUM;
 			sourceTree = "<group>";
+			usesTabs = 0;


what is this?

AmanKAggarwal · 2023-02-15T19:27:37Z

backend/src/config.ts

+let serviceAccountKeyV = "";
+
+/**
+ * Todo: these should throw errors instead of logging messages


Noting to make an issue for this task

AmanKAggarwal · 2023-02-15T19:30:57Z

backend/src/config.ts

+ * Have to do this workaround since lint doesn't let
+ * us export vars
+ */
+const port = portV;


Gotcha! Note to resolve this in the clean backend setup task we will make

AmanKAggarwal · 2023-02-15T19:32:02Z

backend/src/errors/validationError.ts

+ * This class is used to contain any error messages pertaining
+ * to validating inputs.
+ */
+const INVALID_EMAIL_ID = "Invalid email was found, email must not have @iusd.org.";


An issue I faced with this approach in LAKTAA was that as we developed more, we had a lot of error messages so maintaining all of them like this became a pain. Maybe something to note for future

backend/src/middleware/validation.ts

AmanKAggarwal · 2023-02-15T19:36:28Z

backend/src/routes/routes.ts

@@ -1,19 +1,19 @@
-import express, { Request, Response } from "express";
-import { User } from "../models/users";
+// import express, { Request, Response } from "express";


will we need this commented out code in future?

so right, we don't need this anymore

AmanKAggarwal · 2023-02-15T19:41:36Z

backend/src/routes/user.ts

+ *
+ * Mentee: {type: string, name: string, email: string,password: string}
+ */
+router.post(


There are several fields still pending from the figma. This route will be called when the submit button is pressed and it will send all the data collected in the sign-up flow to here. Can you add those fields to the route and model?

add grade, topics of interest, career interests, and what do you hope question

AmanKAggarwal · 2023-02-15T19:42:23Z

backend/src/models/mentor.ts

+  build(attr: MentorInterface): MentorDoc;
+}
+
+const mentorSchema = new mongoose.Schema({


It is kinda important so that the the frontend can be properly integrated with the Signup flow. Since this shouldn't take too long, can we add the fields?

backend/src/routes/user.ts

AmanKAggarwal · 2023-02-15T19:45:00Z

backend/src/services/auth.ts

@@ -0,0 +1,31 @@
+/**


Awesome!! Creating a service for auth and firebase is a great idea. These organizational things might seem not important right now but as our codebase increases in size, its usefulness will become clearer.

AmanKAggarwal

Great work! Let's merge this PR. There are some tasks pending on the mentor/mentee sign-up that we need to resolve as backlog. Can you make 1 task to resolve all this?

Add email regex check for mentor as well
See if logic can be reused between mentor and mentee routes
Add fields from figma so that Sign-Up Flow is done on backend

adhi0331 and others added 21 commits January 25, 2023 15:57

added dependencies

762c565

added authentication for firebase

9f9e9d8

added preliminary create user command

ee31339

added configure file which initializes env vars

69b6a62

Added user model for a mentee

548363b

added mentor model

efaef18

Merge branch 'feature/AdhithyaChristen/FirebaseAuth' of https://githu…

a4c82fb

…b.com/TritonSE/ALUM-Mobile-Application into feature/AdhithyaChristen/FirebaseAuth Adding mentor.ts to models

added validation check message for routes

8cf4c3d

Added mentor/mentee post routes

9d5a396

Added user.ts

a3bbd47

Merge branch 'feature/AdhithyaChristen/FirebaseAuth' of https://githu…

968b9bd

…b.com/TritonSE/ALUM-Mobile-Application into feature/AdhithyaChristen/FirebaseAuth "Adding route files"

Added validators, errors, and cleaned some code

0a9d220

added email field

38159b5

Added additional comments

83a01e2

modified validations to validate mentee/mentor seperately

ddd193c

added regex to validate mentee email

c592b29

split post routes to mentee and mentor routes

c94e9ba

actual routes

4d1445c

working and separated post routes for mentee + mentor, error check fo…

57d4b79

…r bad strings/duplicated email

working and separated post routes for mentee + mentor, error check fo…

9e4a1f4

…r bad strings/duplicated email

lint fixes

8484bea

christen03 requested a review from a team February 11, 2023 08:08

adhi0331 requested a review from AmanKAggarwal February 12, 2023 00:28

AmanKAggarwal requested review from HarshGurnani and adhi0331 and removed request for adhi0331 February 12, 2023 07:41

AmanKAggarwal assigned adhi0331 and christen03 Feb 12, 2023

AmanKAggarwal mentioned this pull request Feb 13, 2023

Sign up confirmation screen + POST call #35

Closed

5 tasks

adhi0331 approved these changes Feb 14, 2023

View reviewed changes

HarshGurnani approved these changes Feb 15, 2023

View reviewed changes

AmanKAggarwal requested changes Feb 15, 2023

View reviewed changes

christen03 added 2 commits February 15, 2023 17:01

deleted unnecessary template route

d58a674

added caketype link

7b64b67

AmanKAggarwal approved these changes Feb 16, 2023

View reviewed changes

AmanKAggarwal merged commit 5743f9e into main Feb 16, 2023

This was referenced Feb 16, 2023

Finish up signup route for mentor/mentee #46

Closed

Cleanup backend setup and throw errors for setup failures #47

Closed

adhi0331 mentioned this pull request Jan 10, 2024

[ Create User Account ] - Backend Route TritonSE/PIA-Program-Manager#7

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/adhithya christen/firebase auth, sign up routes #40

Feature/adhithya christen/firebase auth, sign up routes #40

christen03 commented Feb 11, 2023 •

edited by AmanKAggarwal

Loading

adhi0331 left a comment

adhi0331 Feb 14, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 16, 2023

adhi0331 Feb 14, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 16, 2023

HarshGurnani left a comment •

edited

Loading

AmanKAggarwal left a comment

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 16, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 15, 2023

christen03 Feb 16, 2023

AmanKAggarwal Feb 15, 2023

christen03 Feb 16, 2023

AmanKAggarwal Feb 16, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal Feb 15, 2023

AmanKAggarwal left a comment •

edited

Loading

Feature/adhithya christen/firebase auth, sign up routes #40

Feature/adhithya christen/firebase auth, sign up routes #40

Conversation

christen03 commented Feb 11, 2023 • edited by AmanKAggarwal Loading

Tracking Info

Changes

Testing

Confirmation of Change

adhi0331 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarshGurnani left a comment • edited Loading

Choose a reason for hiding this comment

AmanKAggarwal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmanKAggarwal left a comment • edited Loading

Choose a reason for hiding this comment

christen03 commented Feb 11, 2023 •

edited by AmanKAggarwal

Loading

HarshGurnani left a comment •

edited

Loading

AmanKAggarwal left a comment •

edited

Loading