Sparsebit improvements #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove remainders from an earlier refactoring (local variable `_isDataBoundByPC` is not used) - The check for this variable in UserRuntimeZero was thus always false - However, calls to join (label groups) are already put under a conditional checking the sparse bit in the Stack2JS phase - Also `wrap_block_rhs` seems to already only occour under such a conditional generated by Stack2JS, so that the blocking label is only updated when the sparse bit is not set. The function wrap_block_rhs thus becomes redundant, as it only returns its argument. - Make code less redundant - Use consistent naming: use "sparse bit" in all places, instead of "bound slot" etc.
|
I see that on my side this is failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove remainders from an earlier refactoring (the local variable
_isDataBoundByPCis not used)join, to only apply joins if data is notbounded by PC. However, the branching to avoid such joins is already inserted by Stack2JS,
thus it is redundant here and probably a remainder from earlier refactoring.
wrap_block_rhsis redundant. It was used in the context of updatingthe blocking label through code generated in Stack2JS. It just returned the label to set
the blocking label to, if the sparse bit is not set, and the current blocking label otherwise.
Again this optimization is unnecessary here, as Stack2JS already makes sure that joins are not
executed, and the call to this function itself occurs under a conditional that checks the
sparse bit.
Instead of checking data bounds in the runtime and setting the sparse slot through code
generated by Stack2JS, this is now simplified by doing it completely in the runtime with
the functions
updateSparseBitOnEntry(x: Level)updateSparseBitOnReturn()Use consistent naming: use "sparse bit" all places, instead of "bound slot" etc.
Make code in Stack2JS less redundant