add diff script and results #3037
Conversation
|
|
||
| # Check if the diff output is non-empty | ||
| if [[ -n "$diff_output" ]]; then | ||
| # If it is non-empty, save it to a file in dir3 |
There was a problem hiding this comment.
Can you echo the corresponding curl command into the file here? (And into the expected results.) This would make it easy to copy and paste the curl command to the command line. It would create invalid JSON, so maybe not. Your call.
|
Thanks so much for this. Is it run against the latest Erigon? |
|
I'll merge it once you respond to my questions above. |
|
Ran it against erigon, posted results here: paradigmxyz/reth#3721 (comment) Also added some parameters for placing results in specific folders, to allow multi-way comparison, and added a log file to see which commands were executed |
|
Now that I think about it, these trace tests may be nice to have in their own repo, so people from the future (👋) can reference this non-standard |
Absolutely, 100%. Please feel free to do that. If you need me to help, please let me know. I can put a pointer in the README so there's not two confusing copies. |
|
Would you like me to merge this? Please advise. |
reth folder contains output of run_all for my erigon node
compare_expect_produced.sh runs diffs on produced vs. expected
diffs contains output of compare_expect_produced.sh on those results