Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Fix eslint errors #92

Merged
merged 11 commits into from
Mar 10, 2016
Merged

Fix eslint errors #92

merged 11 commits into from
Mar 10, 2016

Conversation

JoeCortopassi
Copy link
Contributor

go through the new/ and generate/ directories to fix errors discovered by the new eslint rules

static propTypes = {
head: PropTypes.any,
body: PropTypes.any
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static properties should have ;

@toddw
Copy link
Contributor

toddw commented Mar 10, 2016

go through the new/ and generate/ directories to fix errors discovered by the new eslint rules

I'm not seeing any of the files in the generate directory

@christinebrass
Copy link
Contributor

I'm seeing these errors still with our latest eslintrc:

› eslint new generate

/opt/truecar/src/gluestick/new/src/config/application.js
  13:71  error  Missing semicolon  semi

/opt/truecar/src/gluestick/generate/component.test.js
  7:42  error  Unexpected use of undefined  no-undefined

/opt/truecar/src/gluestick/generate/container.test.js
  7:42  error  Unexpected use of undefined  no-undefined

/opt/truecar/src/gluestick/generate/reducer.test.js
  6:15  error  Unexpected use of undefined  no-undefined

✖ 4 problems (4 errors, 0 warnings)

@JoeCortopassi
Copy link
Contributor Author

Got 'em @toddw @Cybrass 👍

@@ -3,7 +3,7 @@ import reducer from "reducers/__$NAME__";
describe("reducers/__$NAME__", () => {
it("returns the initial state", () => {
expect(
reducer(undefined, {})
reducer(void 0, {})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever! In terms of readability, what do you think of this?

it("returns the initial state", () => {
    let state;
    expect(
      reducer(state, {})
    ).to.equal(null);
  });

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christinebrass
Copy link
Contributor

👍

christinebrass added a commit that referenced this pull request Mar 10, 2016
@christinebrass christinebrass merged commit a1b4d73 into TrueCar:develop Mar 10, 2016
@JoeCortopassi JoeCortopassi deleted the fix_eslint_errors branch March 10, 2016 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants