This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Fix eslint errors #92
Merged
christinebrass
merged 11 commits into
TrueCar:develop
from
JoeCortopassi:fix_eslint_errors
Mar 10, 2016
Merged
Fix eslint errors #92
christinebrass
merged 11 commits into
TrueCar:develop
from
JoeCortopassi:fix_eslint_errors
Mar 10, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static propTypes = { | ||
head: PropTypes.any, | ||
body: PropTypes.any | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static properties should have ;
I'm not seeing any of the files in the |
I'm seeing these errors still with our latest eslintrc:
|
@@ -3,7 +3,7 @@ import reducer from "reducers/__$NAME__"; | |||
describe("reducers/__$NAME__", () => { | |||
it("returns the initial state", () => { | |||
expect( | |||
reducer(undefined, {}) | |||
reducer(void 0, {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever! In terms of readability, what do you think of this?
it("returns the initial state", () => {
let state;
expect(
reducer(state, {})
).to.equal(null);
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go through the
new/
andgenerate/
directories to fix errors discovered by the new eslint rules