rust: adds sign_with function
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tl-flavio-barinas
force-pushed
the
rust_adds_sign_with_fn
branch
from
8e09306
to
b8c6be8
Compare
tl-flavio-barinas
changed the title
sign_with function
Lindronics
reviewed
Feb 15, 2024
Lindronics
reviewed
Feb 15, 2024
Lindronics
reviewed
Feb 22, 2024
rust/src/sign/mod.rs
Outdated
Comment on lines
174
to
186
| impl<'a> SignerBuilder<'a, &'a str, Unset, Unset, PhantomData<Get>, &'a str> { | ||
| /// Builds a [`CustomSigner`] | ||
| pub fn build_custom_signer(self) -> CustomSigner<'a> { | ||
| CustomSigner { | ||
| kid: self.kid, | ||
| body: &[], | ||
| method: Get::name(), | ||
| path: self.path, | ||
| headers: self.headers, | ||
| jws_jku: self.jws_jku, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
If we're getting rid of the old sign_with_pem and verify_with_... functions and going for the full breaking change, do we still need the distinction between old (v1) and new "custom" signers/verifiers?
Just wondering if they can be combined and just expose different functions (depending on which types are populated in the builder).
kplattret
reviewed
Mar 4, 2024
kplattret
approved these changes
Mar 5, 2024
Co-authored-by: Kevin Plattret <kevin@plattret.com>
tl-marco-tormento
requested changes
Mar 5, 2024
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Co-authored-by: Marco Tormento <91872926+tl-marco-tormento@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE / bumping from v0.1.3 to v0.2.0
sign_wtihOnce the library is published, I will update the rust examples in a separate PR.