Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AIF360-R components #168

Merged
merged 58 commits into from
May 23, 2020
Merged

Adding AIF360-R components #168

merged 58 commits into from
May 23, 2020

Conversation

SSaishruthi
Copy link
Collaborator

@SSaishruthi SSaishruthi commented Apr 14, 2020 •
edited
Loading

Hello,

This PR contains scripts that act as a wrapper for AIF360 to be used in the R language.

@hoffmansc @gdequeiroz @srnghn

@SSaishruthi
Copy link
Collaborator Author

FYI: @michaelhind @krvarshney @animeshsingh

hoffmansc
hoffmansc reviewed Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@hoffmansc hoffmansc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also like to add these tests to .travis.yml. Ideally, this would run on a separate virtual machine from the python tests so they can be done in parallel (see here and here). Could you add this so we can see the R tests running on Travis? If parallel is too complicated, running them sequentially is fine for now.

aif360/aif360-r/R/utils.R Outdated Show resolved Hide resolved
aif360/aif360-r/inst/extdata/actual_test.csv Outdated Show resolved Hide resolved
nrkarthikeyan
nrkarthikeyan reviewed Apr 24, 2020
View reviewed changes
Copy link
Collaborator

@nrkarthikeyan nrkarthikeyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I have left some comments for your consideration.

aif360/aif360-r/R/binary_label_dataset_metric.R Show resolved Hide resolved
aif360/aif360-r/README.Rmd Show resolved Hide resolved
aif360/aif360-r/README.Rmd Outdated Show resolved Hide resolved
aif360/aif360-r/tests/testthat/test-1.R Show resolved Hide resolved
aif360/aif360-r/tests/testthat/test-adversarial.R Show resolved Hide resolved
aif360/aif360-r/tests/testthat/test-classification.R Outdated Show resolved Hide resolved
aif360/aif360-r/tests/testthat/test-prejudice-remover.R Show resolved Hide resolved
aif360/aif360-r/R/postprocessing_reject_option_classification.R Show resolved Hide resolved
@SSaishruthi
Copy link
Collaborator Author

@hoffmansc Updating Travis test.

@SSaishruthi
Copy link
Collaborator Author

@hoffmansc
Updated Travis to run both Python and R. Can you please have a look at it?

hoffmansc
hoffmansc reviewed May 5, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
hoffmansc
hoffmansc approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@hoffmansc hoffmansc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nrkarthikeyan anything to add before we merge?

.travis.yml Show resolved Hide resolved
@SSaishruthi
Copy link
Collaborator Author

@hoffmansc Are we good to go here?

@hoffmansc hoffmansc merged commit ae55ccc into Trusted-AI:master May 23, 2020
@hoffmansc
Copy link
Collaborator

@SSaishruthi I actually just realized -- didn't we want the R files to be in aif360-r/ in the root directory of the repo, not aif360/aif360-r/?

@SSaishruthi
Copy link
Collaborator Author

SSaishruthi commented May 26, 2020 •
edited
Loading

@hoffmansc @nrkarthikeyan Thank you for reviewing.

@hoffmansc We discussed this in one of our calls. As far as I remember, we want R components to be in the same level as Sklearn components.

Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
@SSaishruthi @srnghn @gdequeiroz
Adding AIF360-R components (Trusted-AI#168)
06ff286 
* Adding AIF360 R components

* Updating README to refer to R documentation for R users

* adding updated test

* adding updated test

* update readme

* update readme

* update readme

* update readme

* update tf

* update pandas

* update pandas

* update readme example

* add travis

* add travis

* update travis

* update travis

* update travis

* update travis

* update travis

* update travis

* update travis

* update travis

* update travis

* update travis

* add python

* update python

* update python

* update python

* update python

* update python virtual env tool

* remove virtual env

* update test file

* update test file

* update test

* add folder change

* change folder path

* change folder path

* change folder path

* change folder path

* change folder path

* change folder path

* change folder path

* merge

* merge

* Add gitignore

* Add .Rbuildignore

* Add cran-comments.md

* Add GH repo url and issues url to DESCRIPTION

* oops - Rename .gitgnore

* Update .Rbuildignore

* Typos

Co-authored-by: srnghn <srnghn@users.noreply.github.com>
Co-authored-by: Gabriela de Queiroz <gabidequeiroz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnghn srnghn srnghn left review comments

@hoffmansc hoffmansc hoffmansc approved these changes

@nrkarthikeyan nrkarthikeyan nrkarthikeyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SSaishruthi @hoffmansc @nrkarthikeyan @srnghn @gdequeiroz