Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing max_iter to 1000 for LogisticRegression used in PrejudiceRemover #254

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

mfeffer
Copy link
Contributor

@mfeffer mfeffer commented Jul 20, 2021

The PrejudiceRemover inprocessing bias mitigation algorithm uses LogisticRegression, and by default, max_iter for LogisticRegression from sklearn is 100. However, in practice, more iterations are occasionally needed to fit PrejudiceRemover to large datasets, some of which are common benchmarks in the fairness literature.

With this in mind, this PR increases the max_iter threshold to 1000 from 100 in order to help PrejudiceRemover properly converge on large datasets.

@nrkarthikeyan
Copy link
Collaborator

@mfeffer - please verify the DCO error and sign off.

Also, can we make this a user-configurable option, so that the default is 100 but can be changed to 1000 or more by users who want them? It will make it easier for users who have smaller datasets to run things quickly.

Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Copy link
Collaborator

@hoffmansc hoffmansc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for now. max_iter is just a budget -- it may use less if possible.

Making this user-configurable will probably have to wait until we rewrite the code for the sklearn-compatible port (#152)

@hoffmansc hoffmansc merged commit c0bd309 into Trusted-AI:master Sep 2, 2022
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants