Fix typo in GridSearchReduction #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linked to issue Trusted-AI#451 of AIF360: Trusted-AI#451 Signed-off-by: haas-christian <34253996+haas-christian@users.noreply.github.com>
|
@hoffmansc, this should be a quick fix which resolves a small issue with GridSearchReduction the base AIF360 library, documented in #451 |
hoffmansc
approved these changes
Apr 5, 2023
|
Can this be merged? |
andrewklayk
pushed a commit
to andrewklayk/AIF360
that referenced
this pull request
Sep 8, 2023
Fix `self.model.moment_`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue #451
The previous version of predict() in GridSearchReduction had a typo where it tried to call
self.model.momentto check which ClassificationMoment the model uses.This should be
self.model.moment_in accordance with the sklearn-compatible version of GridSearchReduction.