This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Removed third step to invite staff users from self-hoster setup #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ really looking forward to not having to skip this every time! |
sanne-san
force-pushed
the
updated-selfhoster-setup-flow
branch
2 times, most recently
from
c12586a
to
ffbdba1
Compare
Codecov Report
@@ Coverage Diff @@
## main #2286 +/- ##
==========================================
- Coverage 41.19% 40.71% -0.49%
==========================================
Files 581 578 -3
Lines 22818 22642 -176
Branches 4041 4007 -34
==========================================
- Hits 9400 9218 -182
- Misses 13418 13424 +6
Continue to review full report at Codecov.
|
sanne-san
force-pushed
the
updated-selfhoster-setup-flow
branch
from
1e7f099
to
c173226
Compare
kevinansfield
added a commit
that referenced
this pull request
Mar 10, 2022
#2286 - `session.authenticate()` returns from it's promise as soon as the authenticate request is completed but it was assumed that it returned after the `session.handleAuthentication()` promise was also completed. A side-effect of that was that depending on network timing, the setup flow could transition to the dashboard before we had loaded all of the necessary user, config, and settings requests - normally that's not a problem because `handleAuthentication()` kicks off a transition once authentication is fully complete, in the setup flow we're handling the transition manually so need a way to manage the full async flow from outside of the session service - it didn't show up as a problem previously because the setup flow transitioned to a third setup screen that didn't require all of the post-auth data to exist - moved the async parts of `session.handleAuthentication()` into a task and updated to return the currently running task instance if one was already running - lets code that is relying on the full authentication flow to have completed call `await this.session.handleAuthentication()` without causing a double-load of the post-auth API requests - updated setup flow - removed manual `session.populateUser()` call as that was a workaround for the async timing issue and caused a double-fetch of the current user API endpoint - added an `await this.session.handleAuthentication()` call to the manual post-auth handler so we don't transition until the full auth flow is complete
kevinansfield
added a commit
that referenced
this pull request
May 27, 2022
refs #2286 - the UI to upload a profile image during setup/signup was removed as part of the auth screens redesign but the related code was left behind
tigefa4u
pushed a commit
to tigefa4u/Ghost
that referenced
this pull request
Aug 3, 2022
TryGhost/Admin#2286 - `session.authenticate()` returns from it's promise as soon as the authenticate request is completed but it was assumed that it returned after the `session.handleAuthentication()` promise was also completed. A side-effect of that was that depending on network timing, the setup flow could transition to the dashboard before we had loaded all of the necessary user, config, and settings requests - normally that's not a problem because `handleAuthentication()` kicks off a transition once authentication is fully complete, in the setup flow we're handling the transition manually so need a way to manage the full async flow from outside of the session service - it didn't show up as a problem previously because the setup flow transitioned to a third setup screen that didn't require all of the post-auth data to exist - moved the async parts of `session.handleAuthentication()` into a task and updated to return the currently running task instance if one was already running - lets code that is relying on the full authentication flow to have completed call `await this.session.handleAuthentication()` without causing a double-load of the post-auth API requests - updated setup flow - removed manual `session.populateUser()` call as that was a workaround for the async timing issue and caused a double-fetch of the current user API endpoint - added an `await this.session.handleAuthentication()` call to the manual post-auth handler so we don't transition until the full auth flow is complete
tigefa4u
pushed a commit
to tigefa4u/Ghost
that referenced
this pull request
Aug 3, 2022
refs TryGhost/Admin#2286 - the UI to upload a profile image during setup/signup was removed as part of the auth screens redesign but the related code was left behind
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue