Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

✨ Ghost OAuth #278

Merged
merged 1 commit into from
Sep 30, 2016
Merged

✨ Ghost OAuth #278

merged 1 commit into from
Sep 30, 2016

Conversation

kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Sep 20, 2016

issue TryGhost/Ghost#7452, requires TryGhost/Ghost#7451

  • use a ghostOAuth config flag to switch between the old-style per-install auth and centralized OAuth auth based on config provided by the server
  • add OAuth flows for:
    • setup
    • sign-in
    • sign-up
    • re-authentication
  • add custom oauth-ghost authenticator to support our custom data structure
  • add test helpers to stub successful/failed oauth authentication
  • hide change password form if using OAuth (temporary - a way to change password via oauth provider will be added later)

TODO:

  • remove hardcoded config value once it's available from the server
  • add tests for patronus flows
    • setup
    • sign-in
    • sign-up
  • 🐛 submitting setup without connecting OAuth account throws error rather than displaying in-line errors
  • hide change password forms when using OAuth
    • tests
  • display name/email of user who created the invite when signing up (requires change on server-side to function correctly)
  • update re-authentication modal to show OAuth connect button

@kevinansfield kevinansfield changed the title Patronus integration [HOLD] Patronus integration Sep 20, 2016
@kevinansfield kevinansfield added this to the 1.0.0-alpha.3 milestone Sep 27, 2016
@kevinansfield kevinansfield self-assigned this Sep 27, 2016
@kirrg001 kirrg001 mentioned this pull request Sep 28, 2016
6 tasks
@kevinansfield kevinansfield changed the title [HOLD] Patronus integration [WIP] Patronus integration Sep 28, 2016
@kevinansfield kevinansfield changed the title [WIP] Patronus integration [WIP] ✨ Ghost OAuth Sep 28, 2016
issue TryGhost/Ghost#7452, requires TryGhost/Ghost#7451
- use a `ghostOAuth` config flag to switch between the old-style per-install auth and centralized OAuth auth based on config provided by the server
- add OAuth flows for:
  - setup
  - sign-in
  - sign-up
  - re-authenticate
- add custom `oauth-ghost` authenticator to support our custom data structure
- add test helpers to stub successful/failed oauth authentication
- hide change password form if using OAuth (temporary - a way to change password via oauth provider will be added later)
@kevinansfield kevinansfield changed the title [WIP] ✨ Ghost OAuth ✨ Ghost OAuth Sep 29, 2016
@kevinansfield
Copy link
Member Author

Ready for review 👓

@kirrg001 kirrg001 merged commit 0a163d7 into TryGhost:master Sep 30, 2016
@sanjibnarzary
Copy link

+1 Signup
Add Social Login too.

@kevinansfield kevinansfield deleted the patronus branch October 3, 2016 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants