This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
💄 refactor setup screens to use ember-concurrency #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Ghost#7865 - moves authentication actions from `signup` route to controller - refactors authentication and signup logic into EC tasks - replaces use of `gh-spin-button` with `gh-task-button` in signup template
11 tasks
refs TryGhost/Ghost#7865 - moves authentication actions from `setup/two` route to controller - refactors authentication and setup logic into EC tasks - replaces use of `gh-spin-button` with `gh-task-button` - fixes some styling issues with the new SVG icons - adds `app/styles/patterns/icons.css` back to contain per-icon overrides and animations (some SVGs use fills and others use strokes so we sometimes have conflicting styles)
kevinansfield
force-pushed
the
setup-ec-refactor
branch
from
986bd12
to
2582fe5
Compare
kevinansfield
changed the title
|
Ready for review 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#7865
setup/tworoute to controllergh-spin-buttonwithgh-task-buttonapp/styles/patterns/icons.cssback to contain per-icon overrides and animations (some SVGs use fills and others use strokes so we sometimes have conflicting styles)TODO:
gh-task-button