Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

🗜 Database soft limits #683

Merged
merged 1 commit into from
May 15, 2017
Merged

🗜 Database soft limits #683

merged 1 commit into from
May 15, 2017

Conversation

aileen
Copy link
Member

@aileen aileen commented May 2, 2017 •
edited
Loading

closes TryGhost/Ghost#8143

  • uses new soft limits in validation:
    • post title to 255
    • meta title (post and tag) to 300
    • meta description (post and tag) to 500
  • updates test

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.551% when pulling 0ae85db on AileenCGN:soft-limits-database into d70ea17 on TryGhost:master.

@kirrg001 kirrg001 self-assigned this May 10, 2017
kirrg001
kirrg001 suggested changes May 10, 2017
View reviewed changes
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to change all meta title/description fields. I think app/validators/tag-settings.js is missing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.741% when pulling 7304fe4 on AileenCGN:soft-limits-database into fbb46dc on TryGhost:master.

@aileen
🗜 Database soft limits
15b3082 
closes TryGhost/Ghost#8143

- uses new soft limits in validation:
	- post title to 255
	- meta title (post and tag) to 300
	- meta description (post and tag) to 500
- updates test
@aileen
Copy link
Member Author

aileen commented May 15, 2017

this is good to go know, @kirrg001

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.741% when pulling 15b3082 on AileenCGN:soft-limits-database into fbb46dc on TryGhost:master.

kirrg001
kirrg001 approved these changes May 15, 2017
View reviewed changes
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kirrg001 kirrg001 merged commit 627a71e into TryGhost:master May 15, 2017
@aileen aileen deleted the soft-limits-database branch October 13, 2017 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirrg001 kirrg001 kirrg001 approved these changes

Assignees

@kirrg001 kirrg001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database soft limits
3 participants
@aileen @coveralls @kirrg001