This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
💄🐷 sort-imports eslint rule #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
approved these changes
May 24, 2017
|
Hmm, what was the error? I already restarted it once, it looked it failed when connecting to npm 😕 |
|
Looks like a syntax error from the mirage config.js |
kevinansfield
force-pushed
the
sort-imports
branch
from
47ab57a
to
7a334c1
Compare
|
Ugh, it's another node v4 incompatibility 😞 I've been running into these more and more frequently lately. I'll see if there's a quick-fix by forking the |
no issue
- adds `eslint-plugin-sort-imports-es6-autofix` dependency
- implements ESLint's base `sort-imports` rule but has a distinction in that `import {foo} from 'bar';` is considered `multiple` rather than `single`
- fixes ESLint's autofix behaviour so `eslint --fix` will actually fix the sort order
- updates all unordered import rules by using `eslint --fix`
With the increased number of `import` statements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify it.
kevinansfield
force-pushed
the
sort-imports
branch
from
7a334c1
to
6457eac
Compare
|
Updated with a fork of the eslint plugin, upstream PR has been opened, hopefully it'll be merged and we can remove the custom fork. |
kirrg001
approved these changes
May 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
eslint-plugin-sort-imports-es6-autofixdependencysort-importsrule but has a distinction in thatimport {foo} from 'bar';is consideredmultiplerather thansingleeslint --fixwill actually fix the sort ordereslint --fixWith the increased number of
importstatements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify and automate it.