Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

tests/gh-task-button: Return Promises instead of using done() #954

Merged
merged 1 commit into from
Feb 3, 2018
Merged

tests/gh-task-button: Return Promises instead of using done() #954

merged 1 commit into from
Feb 3, 2018

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Feb 3, 2018

Newer versions of mocha will complain that done() was called with a non-error argument if used this way. This PR is needed to unblock #922.

/cc @kevinansfield

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.393% when pulling f4b4283 on Turbo87:done into 4d92e5a on TryGhost:master.

@kevinansfield
Copy link
Member

👍 thanks 😄

@kevinansfield kevinansfield merged commit f405899 into TryGhost:master Feb 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @coveralls @kevinansfield