This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
✨ grunt dev admin livereload
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Changes Unknown when pulling 516d75a on kevinansfield:livereload into ** on TryGhost:master**. |
8 tasks
kevinansfield
force-pushed
the
livereload
branch
from
516d75a
to
4df06a1
Compare
kevinansfield
force-pushed
the
livereload
branch
from
4df06a1
to
753d229
Compare
kevinansfield
changed the title
grunt dev admin livereloadgrunt dev admin livereload
kevinansfield
force-pushed
the
livereload
branch
from
753d229
to
28a386d
Compare
refs TryGhost/Ghost#8161, requires tbd - updates the `ember:watch` grunt task to use `ember serve`, passing in the required `--live-reload-base-url` parameter - forces live reload port to `4201` for now as there's a [bug on touchbar macs](ember-cli/ember-cli#6513) - removes the unused `ember-cli-content-security-policy` dependency to remove console log noise from x-domain warnings With this and the required Ghost PR, when using `grunt dev` the admin screen will refresh any time a file is changed. It will also allow tests to be run simultaneously by visiting http://localhost:4200/tests
kevinansfield
force-pushed
the
livereload
branch
from
28a386d
to
148375d
Compare
kevinansfield
added a commit
to kevinansfield/Ghost
that referenced
this pull request
Mar 30, 2017
refs TryGhost#8161, requires TryGhost/Admin#590 - adds a development-only route to the admin app that redirects to ember-cli's livereload script - updates Gruntfile `watch` task to pass the `live-reload-base-url` param with subdirectory support - updates Gruntfile `bgShell:client` task to filter potentially confusing output from `ember serve` - removes `Livereload server on http://localhost:49153` - removes `Serving on http://localhost:4200/` With this and the required Ghost-Admin PR, when using `grunt dev` the admin screen will refresh any time a file is changed. It will also allow client tests to be run simultaneously by visiting http://localhost:4200/tests
ErisDS
pushed a commit
to TryGhost/Ghost
that referenced
this pull request
Mar 30, 2017
refs #8161, requires TryGhost/Admin#590 - adds a development-only route to the admin app that redirects to ember-cli's livereload script - updates Gruntfile `watch` task to pass the `live-reload-base-url` param with subdirectory support - updates Gruntfile `bgShell:client` task to filter potentially confusing output from `ember serve` - removes `Livereload server on http://localhost:49153` - removes `Serving on http://localhost:4200/` With this and the required Ghost-Admin PR, when using `grunt dev` the admin screen will refresh any time a file is changed. It will also allow client tests to be run simultaneously by visiting http://localhost:4200/tests
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#8161, requires TryGhost/Ghost#8176
ember:watchgrunt task to useember serve, passing in the required--live-reload-base-urlparameter4201for now as there's a bug on touchbar macsember-cli-content-security-policydependency to remove console log noise from x-domain warningsWith this and the required Ghost PR, when using
grunt devthe admin screen will refresh any time a file is changed. It will also allow tests to be run simultaneously by visiting http://localhost:4200/tests