✨ grunt dev admin livereload
#8176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
exciting 🙃 |
8 tasks
kevinansfield
force-pushed
the
admin-livereload
branch
from
32195dc
to
11d03f5
Compare
kevinansfield
changed the title
grunt dev admin livereloadgrunt dev admin livereload
ErisDS
reviewed
Mar 29, 2017
core/server/admin/app.js
Outdated
| // Ember CLI's live-reload script | ||
| if (config.get('env') === 'development') { | ||
| adminApp.get('/ember-cli-live-reload.js', function(req, res) { | ||
| res.redirect(`http://localhost:4200${utils.url.getSubdir()}/ghost/ember-cli-live-reload.js`); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kevinansfield
force-pushed
the
admin-livereload
branch
2 times, most recently
from
2f60983
to
d3c8766
Compare
refs TryGhost#8161, requires TryGhost/Admin#590 - adds a development-only route to the admin app that redirects to ember-cli's livereload script - updates Gruntfile `watch` task to pass the `live-reload-base-url` param with subdirectory support - updates Gruntfile `bgShell:client` task to filter potentially confusing output from `ember serve` - removes `Livereload server on http://localhost:49153` - removes `Serving on http://localhost:4200/` With this and the required Ghost-Admin PR, when using `grunt dev` the admin screen will refresh any time a file is changed. It will also allow client tests to be run simultaneously by visiting http://localhost:4200/tests
kevinansfield
force-pushed
the
admin-livereload
branch
from
d3c8766
to
c62f9b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8161, requires TryGhost/Admin#590
watchtask to pass thelive-reload-base-urlparam with subdirectory supportbgShell:clienttask to filter potentially confusing output fromember serveLivereload server on http://localhost:49153Serving on http://localhost:4200/With this and the required Ghost-Admin PR, when using
grunt devthe admin screen will refresh any time a file is changed. It will also allow client tests to be run simultaneously by visiting http://localhost:4200/testsWith this and the required Ghost-Admin PR, when using
grunt devthe admin screen will refresh any time a file is changed. It will also allow client tests to be run simultaneously by visiting http://localhost:4200/testsTODO:
subgrunt:watchtask to pass configured subdirectory aslive-reload-base-urloptionember serveoutput to avoid confusion (see example below)