Show correct importer context objects

refs #9584 - object by reference 🎡 - we modify the object later on - this has resulted in a wrong context output in the admin client - e.g. we've output an updated user reference
TryGhost · Apr 17, 2018 · 2667ad3 · 2667ad3
1 parent f9ffc39
commit 2667ad3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/core/server/data/importer/importers/data/base.js b/core/server/data/importer/importers/data/base.js
@@ -199,7 +199,7 @@ class Base {
             // CASE: you import null, fallback to owner
             if (!obj[key]) {
                 if (!userReferenceProblems[obj.id]) {
-                    userReferenceProblems[obj.id] = {obj: obj, keys: []};
+                    userReferenceProblems[obj.id] = {obj: _.cloneDeep(obj), keys: []};
                 }
 
                 userReferenceProblems[obj.id].keys.push(key);
@@ -217,7 +217,7 @@ class Base {
                 // CASE: fallback to owner
                 if (!existingUser) {
                     if (!userReferenceProblems[obj.id]) {
-                        userReferenceProblems[obj.id] = {obj: obj, keys: []};
+                        userReferenceProblems[obj.id] = {obj: _.cloneDeep(obj), keys: []};
                     }
 
                     userReferenceProblems[obj.id].keys.push(key);
@@ -264,7 +264,7 @@ class Base {
 
                 if (!existingUser) {
                     if (!userReferenceProblems[obj.id]) {
-                        userReferenceProblems[obj.id] = {obj: obj, keys: []};
+                        userReferenceProblems[obj.id] = {obj: _.cloneDeep(obj), keys: []};
                     }
 
                     userReferenceProblems[obj.id].keys.push(key);