Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for markdown reference link syntax as well as inline syntax #2293

Closed
paulspencerwilliams opened this issue Feb 28, 2014 · 11 comments
Closed
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@paulspencerwilliams
Copy link

Whilst writing a simple html scraper to generate the required json for importing into Ghost, I've hit a problem. The html -> markdown service I'm using converts html anchor tags into reference style links as described on the official markdown syntax page.

This syntax appears to work when viewing a full blog post but doesn't render correctly in the blog list page, nor in the editor.

I'm using ghost.org hosting thus running version 0.4.1.

@ErisDS
Copy link
Member

ErisDS commented Feb 28, 2014

Can you please provide a sample of the markdown that was generated?

@paulspencerwilliams
Copy link
Author

Sorry, this is the json I scrapped and uploaded to the ghost.org service including the markdown attribute.

{"posts_tag":[],"tags":[],"meta":{"exported_on":1393622680831,"version":"000"},"data":{"posts":[{"status":"published","slug":"Llynnau Mymbyr","featured":0,"meta_description":null,"updated_at":1334012400000,"created_by":1,"page":0,"updated_by":1,"image":null,"language":"en_GB","title":"Llynnau Mymbyr","created_at":1334012400000,"markdown":"![8055881557_58006d8962_b.jpg][1]\n\nI took this shot on the way up to my first wildcamp of 2012 on Moel Siabod.\n\n   [1]: http:\/\/farm9.static.flickr.com\/8040\/8055881557_58006d8962_b.jpg (Sunset over Llynnau Mymbyr)\n","meta_title":"Llynnau Mymbyr","published_by":1,"author_id":1,"id":1,"published_at":1334012400000}]}}

@ErisDS
Copy link
Member

ErisDS commented Feb 28, 2014

Thanks

@paulspencerwilliams
Copy link
Author

@ErisDS oh, and congrats on moving your blog over to ghost. I've migrated one from wordpress.com, one from octopress markdown, and this is the last blog. Unfortunately, I lost the markdown, hence writing a scrapper in Clojure; any excuse to write some code ;-)

@ErisDS
Copy link
Member

ErisDS commented Feb 28, 2014

@paulspencerwilliams All my WP content was soooo old.. I couldn't decide whether to keep it or not :/

... and it's full of PHP 😊

@paulspencerwilliams
Copy link
Author

Update, the following markdown is supported:

[![Sunset over Llynnau Mymbyr][image-1]][2]

I took this shot on the way up to my first wildcamp of 2012 on Moel Siabod.


[image-1]: http://farm9.static.flickr.com/8040/8055881557_58006d8962_b.jpg
[2]: http://www.flickr.com/photos/goatifiedcreature/8055881557/

although the previously updated content has the initially described errors

![8055881557_58006d8962_b.jpg][1]\n\nI took this shot on the way up to my first wildcamp of 2012 on Moel Siabod.\n\n   [1]: http:\/\/farm9.static.flickr.com\/8040\/8055881557_58006d8962_b.jpg (Sunset over Llynnau Mymbyr)\n

@ErisDS
Copy link
Member

ErisDS commented Mar 2, 2014

I'm completely confused now - can you perhaps update the original issue to follow the bug report format? Including all information and reproduction steps in the original issue, rather than adding via comments. Yep I know - I'm totally asking for you to spell it out, there is so much traffic here that it becomes too much if every issue requires further reading to understand it 😉

Thanks 👍

@ErisDS ErisDS added this to the 0.7 milestone Mar 4, 2014
@paulspencerwilliams
Copy link
Author

Will do - off project for a week or so, but do ASAP

@ErisDS
Copy link
Member

ErisDS commented Aug 19, 2014

This isn't going to progress without the new editor. Closing as wontfix against #1294

@ErisDS ErisDS closed this as completed Aug 19, 2014
@ErisDS ErisDS removed this from the 0.7 Editor milestone Aug 20, 2014
@yorkxin
Copy link

yorkxin commented Dec 23, 2014

This feature fits my requirement. Would you consider add it back again?

@yorkxin
Copy link

yorkxin commented Dec 23, 2014

Sorry, I was wrong. It was supported. I just put them in <table> so it didn't work. Hopefully one day you can support tables so that I don't have to worry about this anymore :)

tigefa4u pushed a commit to tigefa4u/Ghost that referenced this issue Aug 3, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Development

No branches or pull requests

3 participants