Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly loading an editor URL results in empty content #9077

Closed
kevinansfield opened this issue Sep 28, 2017 · 1 comment · Fixed by #9078
Closed

Directly loading an editor URL results in empty content #9077

kevinansfield opened this issue Sep 28, 2017 · 1 comment · Fixed by #9078
Assignees
@kirrg001
Labels
bug [triage] something behaving unexpectedly server / core Issues relating to the server or core of Ghost

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Sep 28, 2017 •
edited

Issue Summary

If you access an editor URL directly (eg. http://ghost.blog/ghost/#/editor/59c27dcda3a99a2a33e8bdb3) then the post content will not be displayed in the editor

Steps to Reproduce

  1. Open a post in the editor
  2. Refresh the page
  3. Note that the post content is now missing

Opening the editor via a URL should be no different to navigating from the posts list.

After investigating, the client appears to be doing the correct thing but the API is not returning the correct formats.

Client loads an individual post when accessed via URL, http://ghost.blog/ghost/api/v0.1/posts/59c27dcda3a99a2a33e8bdb3/?status=all&staticPages=all&formats=mobiledoc%2Cplaintext&include=tags - the response from the API is only returning the html attribute, not mobiledoc and plaintext as specified in the URL.

Technical details:

  • Ghost Version: master
  • Browser/OS: Chrome/macOS
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Sep 28, 2017
@kevinansfield kevinansfield added server / core Issues relating to the server or core of Ghost and removed affects:admin Anything relating to Ghost Admin labels Sep 28, 2017
@kirrg001
Copy link
Contributor

Fix is coming. Outcome of #9068. This PR fixed a fundamental bug with our API options/context object.

@kirrg001 kirrg001 mentioned this issue Sep 28, 2017
Merged
kirrg001 added a commit to kirrg001/Ghost that referenced this issue Sep 28, 2017
@kirrg001
Fixed wrong handling of formats param
16a7653 
closes TryGhost#9077

- because of our API layer refactoring, see TryGhost#9068
- we can now see that code was written wrong because of this horrible API bug
- this fixes the formats parameter for querying a single post
kevinansfield pushed a commit that referenced this issue Sep 28, 2017
@kirrg001 @kevinansfield
Fixed wrong handling of formats param (#9078)
d3d04a8 
closes #9077

- because of our API layer refactoring, see #9068
- we can now see that code was written wrong because of this horrible API bug
- this fixes the formats parameter for querying a single post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirrg001 kirrg001

Labels
bug [triage] something behaving unexpectedly server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed wrong handling of formats param kirrg001/Ghost
2 participants
@kevinansfield @kirrg001