Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong handling of formats param #9078

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Sep 28, 2017

closes #9077

This allows an extra formats option (next to include and context).

@@ -105,7 +105,7 @@ posts = {

// Push all of our tasks into a `tasks` array in the correct order
tasks = [
apiUtils.validate(docName, {attrs: attrs, opts: options.opts || []}),
apiUtils.validate(docName, {attrs: attrs, opts: options.opts || ['formats']}),

This comment was marked as abuse.

This comment was marked as abuse.

@kirrg001 kirrg001 changed the title Fixed wrong handling of formats param [WIP] Fixed wrong handling of formats param Sep 28, 2017
@kirrg001 kirrg001 changed the title [WIP] Fixed wrong handling of formats param Fixed wrong handling of formats param Sep 28, 2017
closes TryGhost#9077

- because of our API layer refactoring, see TryGhost#9068
- we can now see that code was written wrong because of this horrible API bug
- this fixes the formats parameter for querying a single post
@kevinansfield
Copy link
Member

👍 working for me 😄

@kevinansfield kevinansfield merged commit d3d04a8 into TryGhost:master Sep 28, 2017
@kevinansfield kevinansfield deleted the fix-wrong-read-api-post branch September 28, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directly loading an editor URL results in empty content
2 participants