API layer refactoring && avoid bypassing filtering options in User model #9068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge both commits separate.
First commit: Refactored the API layer: do not handle API response after pipelining
toJSON
function of a modeltoJSON
function to determine which model fields to return, we cannot do that without this change!NOTE: I thought about a util for the response format, but i decided against at the moment, because i am not sure if we have to change a fundamental concept of how the API works (who returns what, who returns JSON, how do we guarantee that the options object is everywhere accessible, how are headers generated etc.). See for example this here - it only happens because the outer API level wants to add headers based on the state of a model.
Second commit: Removed bypassing option filtering in User model