Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enabled Portal #12317

Merged
merged 11 commits into from
Nov 3, 2020
Merged

Conversation

rishabhgrg
Copy link
Contributor

@rishabhgrg rishabhgrg commented Nov 2, 2020

This PR releases Portal, the drop-in script to make the bulk of Ghost membership features work on any theme, to public which Portal enabled for all sites as default.
Note: Portal is still under active development and in Beta as of today.

  • Enables Ghost default config to switch on Portal for all sites
  • Adds migration to switch off visibility of Portal button for all existing sites, which can be toggled back on from Ghost-Admin

Copy link
Contributor

@allouis allouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes the change to the default config, which will set all sites to have a portal config of true, unless they have explicitly overridden it.

I think this should be in a separate version, otherwise the migration will only run for people that have explicitly disabled portal, which is undesirable, right?

no refs

- The Portal button setting was set as `true` since Ghost 3.23 which meant all new sites since that version had Portal button visible by default if Portal was enabled.
- Since Portal is now enabled by default for all sites, we hide the Portal button for any existing sites which did not have Portal enabled yet. All sites that have Portal enabled currently are unchanged.
- All new sites created will have Portal button visible by default and will need to be explicitly hidden if needed
@rishabhgrg rishabhgrg force-pushed the portal-public-release branch 3 times, most recently from a6fa592 to 0f1383a Compare November 2, 2020 19:05
no refs

Portal was previously disabled by default for any site and had to be enabled by toggling the config flag to `true`. The commit removes Portal from behind the flag and adds it as default, which means all sites will have access to Portal with this release.
no refs

The existing public members script is now being removed in favor or Portal script which is loaded for all sites by default, and handles all existing usecases.
@rishabhgrg rishabhgrg changed the title ✨Enabled Portal for all sites ✨ Enabled Portal Nov 3, 2020
@rishabhgrg rishabhgrg merged commit 8ad11fe into TryGhost:master Nov 3, 2020
@rishabhgrg rishabhgrg deleted the portal-public-release branch November 3, 2020 09:06
@rickdonato
Copy link

Nice feature. And appreciate it is still in beta, but it should certainly be disabled by default.

@rishabhgrg
Copy link
Contributor Author

rishabhgrg commented Nov 17, 2020

Hey @rickdonato , Portal is backwards compatible and doesn't cause any behavior change for existing sites. It just adds extra membership features for sites and can be customised or hidden via Ghost-Admin. In case it did cause any unwanted side-effects for your site do let us know :)

@rickdonato
Copy link

Hey @rishabhgrg, Unfortunately it is causing issues. My site already had membership enabled and the required profile pages etc.
With the portal feature enabled, even though I have removed the button via the portal setting, when users edit their payment details, and return to the site, the modal still appears. It would be great to be able to complete disable this feature via the admin portal. From what I can see this would just involve excluding the js file from being added to the DOM.

@matthanley
Copy link
Contributor

Hey @rickdonato 👋

Thanks for reporting the issue for your specific use-case. Please open a new issue following our issue template so we can look into it further.

Thanks!

@rickdonato
Copy link

This has now been raised against #12392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants