-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enabled Portal #12317
✨ Enabled Portal #12317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes the change to the default config, which will set all sites to have a portal
config of true
, unless they have explicitly overridden it.
I think this should be in a separate version, otherwise the migration will only run for people that have explicitly disabled portal, which is undesirable, right?
no refs - The Portal button setting was set as `true` since Ghost 3.23 which meant all new sites since that version had Portal button visible by default if Portal was enabled. - Since Portal is now enabled by default for all sites, we hide the Portal button for any existing sites which did not have Portal enabled yet. All sites that have Portal enabled currently are unchanged. - All new sites created will have Portal button visible by default and will need to be explicitly hidden if needed
a6fa592
to
0f1383a
Compare
no refs Portal was previously disabled by default for any site and had to be enabled by toggling the config flag to `true`. The commit removes Portal from behind the flag and adds it as default, which means all sites will have access to Portal with this release.
0f1383a
to
9566f87
Compare
no refs The existing public members script is now being removed in favor or Portal script which is loaded for all sites by default, and handles all existing usecases.
Nice feature. And appreciate it is still in beta, but it should certainly be disabled by default. |
Hey @rickdonato , Portal is backwards compatible and doesn't cause any behavior change for existing sites. It just adds extra membership features for sites and can be customised or hidden via Ghost-Admin. In case it did cause any unwanted side-effects for your site do let us know :) |
Hey @rishabhgrg, Unfortunately it is causing issues. My site already had membership enabled and the required profile pages etc. |
Hey @rickdonato 👋 Thanks for reporting the issue for your specific use-case. Please open a new issue following our issue template so we can look into it further. Thanks! |
This has now been raised against #12392 |
This PR releases Portal, the drop-in script to make the bulk of Ghost membership features work on any theme, to public which Portal enabled for all sites as default.
Note: Portal is still under active development and in Beta as of today.