Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal is not disabled when disabling the Button. #12392

Closed
rickdonato opened this issue Nov 20, 2020 · 3 comments
Closed

Portal is not disabled when disabling the Button. #12392

rickdonato opened this issue Nov 20, 2020 · 3 comments
Assignees

Comments

@rickdonato
Copy link

Issue Summary

This issue is based on the portal feature. My site already had membership enabled and the required profile pages etc.
With the portal feature enabled, even though I have removed the button via the portal setting, when users edit their payment details, and return to the site, the modal still appears. It would be great to be able to complete disable this feature via the admin portal. From what I can see this would just involve excluding the js file from being added to the DOM..

To Reproduce

Install ghost with portal enabled. Disable the portal button, and enable membership. Then perform user member updates as user, via the member links (stripe) etc but not via the portal.

Technical details:

  • Ghost Version: 3.38.1
  • Node Version: TBC
  • Browser/OS: Chrome Windows 10
  • Database: MySQL
@rishabhgrg rishabhgrg self-assigned this Nov 23, 2020
@rishabhgrg
Copy link
Contributor

Hey @rickdonato , thanks for raising. I looked into this and the earlier Portal script definitely had this issue where it showed the modal even if user edited their payment details via non-portal source. The latest version of Portal has fixed this and will only show modal if the billing change is done via Portal directly, otherwise not. You should be able to try it out without any changes on your end as we always load the latest version of script.

Excluding the portal js file in DOM is not a good solution because the file not only handles the modal but also any member interaction directly on theme as well so without the script none of the member actions will work

@rickdonato
Copy link
Author

Thanks can you confirm what version fixes this.

@rishabhgrg
Copy link
Contributor

rishabhgrg commented Nov 27, 2020

@rickdonato The fix is live in Portal v0.13.1. Let us know if it still causes any unexpected behavior with latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants