-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image background colour #4
Comments
Transparent I'd say - feel free to PR! |
Drew did this on purpose. There was a white loading gif on top of the grey that was there while loading. Noticed the gif didn't get ported over Sam On Wed, Dec 10, 2014 at 7:44 AM, JohnONolan notifications@github.com
|
@soffes ok, probably better to port it over then. What happens though when the image is transparent? Now you're left with an awful looking image. |
It's only while loading Sam On Wed, Dec 10, 2014 at 9:21 AM, James Brooks notifications@github.com
|
So some JavaScript is ensuring that once the load is done, the background is changed? |
Yes. Sam On Wed, Dec 10, 2014 at 9:22 AM, James Brooks notifications@github.com
|
Like Sam says, the JavaScript that handled this was removed when I ported the theme over. I think the best course of action here (if you still looking to contribute @jbrooksuk ?) is to just remove any code related to the loading of images. |
Currently the background on an image is a dull grey. Since the background of the
body
is white, shouldn't the image background be transparent or at least white?The text was updated successfully, but these errors were encountered: