Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image background colour #4

Closed
jbrooksuk opened this issue Dec 10, 2014 · 7 comments
Closed

Image background colour #4

jbrooksuk opened this issue Dec 10, 2014 · 7 comments

Comments

@jbrooksuk
Copy link

Currently the background on an image is a dull grey. Since the background of the body is white, shouldn't the image background be transparent or at least white?

@JohnONolan
Copy link
Member

Transparent I'd say - feel free to PR!

@soffes
Copy link
Contributor

soffes commented Dec 10, 2014

Drew did this on purpose. There was a white loading gif on top of the grey that was there while loading. Noticed the gif didn't get ported over

Sam

On Wed, Dec 10, 2014 at 7:44 AM, JohnONolan notifications@github.com
wrote:

Transparent I'd say - feel free to PR!

Reply to this email directly or view it on GitHub:
#4 (comment)

@jbrooksuk
Copy link
Author

@soffes ok, probably better to port it over then. What happens though when the image is transparent? Now you're left with an awful looking image.

@soffes
Copy link
Contributor

soffes commented Dec 10, 2014

It's only while loading

Sam

On Wed, Dec 10, 2014 at 9:21 AM, James Brooks notifications@github.com
wrote:

@soffes ok, probably better to port it over then. What happens though when the image is transparent? Now you're left with an awful looking image.

Reply to this email directly or view it on GitHub:
#4 (comment)

@jbrooksuk
Copy link
Author

So some JavaScript is ensuring that once the load is done, the background is changed?

@soffes
Copy link
Contributor

soffes commented Dec 10, 2014

Yes.

Sam

On Wed, Dec 10, 2014 at 9:22 AM, James Brooks notifications@github.com
wrote:

So some JavaScript is ensuring that once the load is done, the background is changed?

Reply to this email directly or view it on GitHub:
#4 (comment)

@PaulAdamDavis
Copy link
Member

Like Sam says, the JavaScript that handled this was removed when I ported the theme over.

I think the best course of action here (if you still looking to contribute @jbrooksuk ?) is to just remove any code related to the loading of images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants