Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos-latest -> macos-12 #2482

Merged
merged 5 commits into from
Apr 25, 2024
Merged

macos-latest -> macos-12 #2482

merged 5 commits into from
Apr 25, 2024

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Apr 25, 2024

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@EmiM EmiM changed the title test: ci macos-latest -> macos-12 Apr 25, 2024
@EmiM
Copy link
Contributor Author

EmiM commented Apr 25, 2024

macos-latest upgraded its image to macos-14:
https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/#:~:text=The%20macOS%2012%20runner%20image%20will%20remain%20latest%20until%20migration%20of%20the%20latest%20YAML%20workflow%20label%20to%20macOS%2014%20in%20Q2%20FY24%20(April%20%E2%80%93%20June%202024).

This caused some issues for setup-env step on desktop:
https://github.com/TryQuiet/quiet/actions/runs/8831814470/job/24247807269?pr=2482
macOS%2014%20in%20Q2%20FY24%20(April%20%E2%80%93%20June%202024))

githubMacosUpgrade.log
We have to address this at some point but it's faster to just keep using previous image for now.

@EmiM EmiM merged commit 14b6106 into develop Apr 25, 2024
9 checks passed
@EmiM EmiM deleted the test/mac-ci branch April 25, 2024 13:35
adrastaea pushed a commit that referenced this pull request Apr 25, 2024
@EmiM @adrastaea
macos-latest -> macos-12 (#2482)
f1f076d 
* fix: use explicit macos-12 image instead of macos-latest ('-latest' image was updated to macos-14)
islathehut pushed a commit that referenced this pull request May 9, 2024
@EmiM @islathehut
macos-latest -> macos-12 (#2482)
4cd24e9 
* fix: use explicit macos-12 image instead of macos-latest ('-latest' image was updated to macos-14)
islathehut pushed a commit that referenced this pull request May 9, 2024
@EmiM
Chore: Use macos-12 on 2.2.0 (#2515)
c51d29a 
* macos-latest -> macos-12 (#2482)

* fix: use explicit macos-12 image instead of macos-latest ('-latest' image was updated to macos-14)

* Update e2e-mac.yml

* Run e2e on e2e changes

---------

Co-authored-by: breadhunter <6099829+EmiM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmiM