-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Id views to using new menu code #750
Conversation
Issues I don't like
be its own function in core/id? Since all it does is resolve via either |
padinfo/id_menu_old.py
Outdated
@@ -4,6 +4,8 @@ | |||
import discord | |||
from discord import Color | |||
|
|||
from padinfo.core.padinfo_settings import settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this entire file be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still links
and lssingle
3ac9dd2
to
4419148
Compare
|
||
def serialize(self): | ||
ret = super().serialize() | ||
ret.update({ | ||
'pane_type': 'materials', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define a class with string so this isn't hardcoded.
@staticmethod | ||
def get_pane_types(): | ||
return { | ||
'id': IdMenu.respond_with_current_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define a class with strings so the key isn't hardcoded.
@@ -10,34 +10,40 @@ | |||
|
|||
class PicViewState(ViewState): | |||
def __init__(self, original_author_id, menu_type, raw_query, query, color, monster: "MonsterModel", | |||
use_evo_scroll: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case anyone is reading this later - if these views are used outside of the ^id
command (which IdViewState
is), it's possible we won't care about the use_evo_scroll
preference and not have determined that so we don't require it
Outstanding issues from #741