Remove hard code video format limitation #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open issue: #98
Problem:
Currently, we hardcore the
MediaModel
to only accept.m3u8
format, that puts the limitation ofTubiplayer
only accepthls
video format.solution
By removing the hardcode
getMediaExtension
isMediaModel
, the Tubiplayer will automatically create differentMediaSource
base on url extension.See below logic for handle automatically
MediaSource
creation: https://github.com/Tubitv/TubiPlayer/blob/master/lib/src/main/java/com/tubitv/media/activities/TubiPlayerActivity.java#L202