Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard code video format limitation #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allengotstuff
Copy link
Member

@allengotstuff allengotstuff commented Jul 16, 2019

Open issue: #98

Problem:

Currently, we hardcore the MediaModel to only accept .m3u8 format, that puts the limitation of Tubiplayer only accept hls video format.

solution

By removing the hardcode getMediaExtension is MediaModel, the Tubiplayer will automatically create different MediaSource base on url extension.

See below logic for handle automatically MediaSource creation: https://github.com/Tubitv/TubiPlayer/blob/master/lib/src/main/java/com/tubitv/media/activities/TubiPlayerActivity.java#L202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants