Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the name convention #139

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Change the name convention #139

merged 1 commit into from
Oct 4, 2023

Conversation

datejada
Copy link
Member

@datejada datejada commented Oct 4, 2023

Pull request details

Describe the changes made in this pull request

Changes in the code to remove "p_" and "s_"

List of related issues or pull requests

Closes #123

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@datejada datejada requested a review from gnawin October 4, 2023 13:32
@datejada datejada self-assigned this Oct 4, 2023
gnawin
gnawin approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@gnawin gnawin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. It looks good to me.

@gnawin gnawin merged commit 6c3d2a2 into TulipaEnergy:main Oct 4, 2023
11 checks passed
@datejada datejada deleted the 123-revise-jump-model-naming-convention branch October 4, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnawin gnawin gnawin approved these changes

Assignees

@datejada datejada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revise the naming convention for everything (e.g., p_*)
2 participants
@datejada @gnawin