Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transport capacity #357

Merged

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Dec 13, 2023

Pull request details

Describe the changes made in this pull request

The transport capacity has been refactored.

List of related issues or pull requests

Closes #345 #305

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@gnawin gnawin marked this pull request as draft December 13, 2023 15:17
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc8e169) 100.00% compared to head (8d36378) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          297       296    -1     
=========================================
- Hits           297       296    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnawin gnawin marked this pull request as ready for review December 13, 2023 15:40
@gnawin gnawin requested a review from datejada December 13, 2023 15:40
@gnawin gnawin force-pushed the 345-transport-assets-capacity-refactor branch from 348b285 to 8d36378 Compare December 13, 2023 16:01
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@datejada datejada merged commit d75d3c1 into TulipaEnergy:main Dec 13, 2023
6 checks passed
@gnawin gnawin linked an issue Dec 14, 2023 that may be closed by this pull request
@gnawin gnawin deleted the 345-transport-assets-capacity-refactor branch February 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants