Create new parameters for storage methods #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #544 to rebase this branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 642 642
=========================================
Hits 642 642 ☔ View full report in Codecov by Sentry. |
|
This can be merged now. But I'd rather wait for @datejada to check the new design (#575 (comment)) and the names so we don't have to revamp this in case something needs to be changed. |
gnawin
changed the title
gnawin
force-pushed
the
600-create-parameters-storage-methods
branch
from
e61f71a
to
c48bcff
Compare
gnawin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
Describe the changes made in this pull request
Create new parameters, and change the input data accordingly.
List of related issues or pull requests
Closes #600
Collaboration confirmation
As a contributor I confirm