-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
shore-leave
commented
May 22, 2020
- App icons replaced
- Notification icons replaced
- Splash icons replaced
- Asset source file included
- Asset docs
- Debug app name changed from "Dawn (d)" to "Dusk (d)" (keep or discard "(d)"?)
- Change app theme
- Make new subreddit(?)
- Finish "Attributions and licenses" section (important)
- Update screenshots and other public branding (such as Play Store listing)
I think we can remove (d), having a different name is a unique concept anyway so it should be enough 🙂
What do you mean here exactly? Adjusting colors to match these from Dawn icon or something else? |
Yes they clash a bit now. #166 seems related, would you be interested in getting it merged first? If so what needs to be done for that? |
While the linked pull request has a lot of good work done, there was never a proper design prepared for the light theme. It does work but there are a lot of colors which have bad constrast in the light theme or some just seem not fitting to the application (based on my unprofessional opinion). Unfortunately myself I’m unable to help in that regard as I’m pretty bad at choosing colors. Potentially we could merge it for now as a debug only feature until we have a proper design but I’m not sure whether that’s a good idea. |
I'm willing to put in some work on making a light theme as well. I've got today almost completely free. I'd be happy to get on it if you want. Off topic: Is there an easy way to send a debug notification? I never tested the notification icons because I couldn't figure out how |
Sure I don’t have anything agains that.
If you download images you receive notification, but these use different icons. Other than that probably only if you add temporary code or receive a private message. |
I would just suggest not adding that here but making it a separate pull request. Smaller focused pull requests are always better. |
@shore-leave Is there anything that you need help with in order to get this finished? |
@Tunous sorry I forgot to remove the WIP when I finished it. This one is ready. Up next is the theming which I've been slowly working on. I'll copy the info from this one over to the rebranding thread Edit: Actually I think I forgot to update the app name. Should be quick enough that I can do it now |