Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

App rebranding #212

Merged
merged 6 commits into from
Jun 13, 2020
Merged

App rebranding #212

merged 6 commits into from
Jun 13, 2020

Conversation

shore-leave
Copy link

  • App icons replaced
  • Notification icons replaced
  • Splash icons replaced
  • Asset source file included
  • Asset docs
  • Debug app name changed from "Dawn (d)" to "Dusk (d)" (keep or discard "(d)"?)
  • Change app theme
  • Make new subreddit(?)
  • Finish "Attributions and licenses" section (important)
  • Update screenshots and other public branding (such as Play Store listing)

@shore-leave shore-leave mentioned this pull request May 22, 2020
@Tunous
Copy link
Owner

Tunous commented May 22, 2020

Debug app name changed from "Dawn (d)" to "Dusk (d)" (keep or discard "(d)"?)

I think we can remove (d), having a different name is a unique concept anyway so it should be enough 🙂

Change app theme

What do you mean here exactly? Adjusting colors to match these from Dawn icon or something else?

@shore-leave
Copy link
Author

shore-leave commented May 22, 2020

Adjusting colors to match these from Dawn icon or something else?

Yes they clash a bit now. #166 seems related, would you be interested in getting it merged first? If so what needs to be done for that?

@Tunous
Copy link
Owner

Tunous commented May 22, 2020

While the linked pull request has a lot of good work done, there was never a proper design prepared for the light theme. It does work but there are a lot of colors which have bad constrast in the light theme or some just seem not fitting to the application (based on my unprofessional opinion). Unfortunately myself I’m unable to help in that regard as I’m pretty bad at choosing colors.

Potentially we could merge it for now as a debug only feature until we have a proper design but I’m not sure whether that’s a good idea.

@Tunous Tunous mentioned this pull request May 22, 2020
@shore-leave
Copy link
Author

I'm willing to put in some work on making a light theme as well. I've got today almost completely free. I'd be happy to get on it if you want.

Off topic: Is there an easy way to send a debug notification? I never tested the notification icons because I couldn't figure out how

@Tunous
Copy link
Owner

Tunous commented May 22, 2020

I'm willing to put in some work on making a light theme as well. I've got today almost completely free. I'd be happy to get on it if you want.

Sure I don’t have anything agains that.

Is there an easy way to send a debug notification? I never tested the notification icons because I couldn't figure out how

If you download images you receive notification, but these use different icons. Other than that probably only if you add temporary code or receive a private message.

@Tunous
Copy link
Owner

Tunous commented May 22, 2020

I would just suggest not adding that here but making it a separate pull request. Smaller focused pull requests are always better.

@Tunous
Copy link
Owner

Tunous commented Jun 12, 2020

@shore-leave Is there anything that you need help with in order to get this finished?

@shore-leave
Copy link
Author

shore-leave commented Jun 12, 2020

@Tunous sorry I forgot to remove the WIP when I finished it. This one is ready. Up next is the theming which I've been slowly working on. I'll copy the info from this one over to the rebranding thread

Edit: Actually I think I forgot to update the app name. Should be quick enough that I can do it now
Edit 2: Ready!

@shore-leave shore-leave changed the title [WIP] App rebranding App rebranding Jun 12, 2020
@Tunous Tunous merged commit de055a2 into Tunous:master Jun 13, 2020
@Tunous Tunous added the design Changes to the design of the app label Jun 13, 2020
@Tunous Tunous added this to the 0.9.2 milestone Jun 13, 2020
@Tunous Tunous mentioned this pull request Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Changes to the design of the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants