Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Allow cleartext traffic for proxy server #50

Closed
wants to merge 1 commit into from
Closed

Allow cleartext traffic for proxy server #50

wants to merge 1 commit into from

Conversation

msfjarvis
Copy link
Collaborator

Allow cleartext traffic for proxy server
ecea968 
Fixes https://del.dog/uwikuqujeg.sql

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@Tunous
Copy link
Owner

Tunous commented Aug 19, 2019

Hey, thank you for the fix!

Could you describe a simple use case how we could reproduce that issue to confirm the fix?

@msfjarvis
Copy link
Collaborator Author

Hey, thank you for the fix!

Could you describe a simple use case how we could reproduce that issue to confirm the fix?

Trying to play a GIF will always re-download because the cache service will crash without this commit, you can confirm that by monitoring logcat for exceptions before and after the patch.

@Tunous Tunous added the bug Something isn't working label Aug 19, 2019
@Tunous
Copy link
Owner

Tunous commented Aug 19, 2019

I've reproduced the problem and confirmed that the fix indeed resolved the issue 👍

I'll squash this manually to also introduce changelog entry as single commit, hopefully it shouldn't remove your authorship of the commit.

Tunous pushed a commit that referenced this pull request Aug 19, 2019
@Tunous
Allow cleartext traffic for proxy server (#50)
d3bba45 
Fixes https://del.dog/uwikuqujeg.sql

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
@Tunous
Copy link
Owner

Tunous commented Aug 19, 2019

Squashed as d3bba45.

@Tunous Tunous closed this Aug 19, 2019
@Tunous Tunous added this to the 0.8.0 milestone Aug 19, 2019
@Tunous Tunous mentioned this pull request Aug 19, 2019
Merged
@msfjarvis msfjarvis deleted the temp branch August 19, 2019 17:34
mvietri pushed a commit to mvietri/Dawn that referenced this pull request Aug 24, 2019
Allow cleartext traffic for proxy server (Tunous#50)
8c86453 
Fixes https://del.dog/uwikuqujeg.sql

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msfjarvis @tunous-bot @Tunous