Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numpy visible in the docs #50

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Make numpy visible in the docs #50

merged 1 commit into from
Aug 22, 2020

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented May 4, 2020

For my project https://github.com/eumiro/pygohome I needed a lat/lon to utm converter to convert 100k+ of coordinates at once. Unfortunately using utm.from_latlon for individual coordinates in a loop took too much time. Only after I studied the code and history of the project, I discovered the NumPy support, which made it fast again and I'll add it to the project again.
That's why I added the mention and code examples of Numpy usage into the README.rst and the API. At the same time I completed the API doc, cleaned it a little bit, and fixed some typos. Hope you like it.

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files           3        3           
  Lines         160      160           
=======================================
  Hits          152      152           
  Misses          8        8           
Impacted Files Coverage Δ
utm/conversion.py 94.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875f0de...5f956f5. Read the comment docs.

Copy link
Owner

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late reply. this looks awesome. thanks a lot! :)

@Turbo87 Turbo87 merged commit e4c12af into Turbo87:master Aug 22, 2020
@eumiro eumiro deleted the eumiro-make-numpy-visible branch October 16, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants