Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIM: Avoid errors from _ensure_orig_key when positional $ is used #25

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

brondsem
Copy link
Collaborator

There may well be a better way to do this, but this avoids an error from _ensure_orig_key when a positional $ is used in the middle of dotted notation. (This test passes with earlier versions of ming before _ensure_orig_key was added)

@coveralls
Copy link

coveralls commented Jun 18, 2020

Pull Request Test Coverage Report for Build 106

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 88.627%

Files with Coverage Reduction New Missed Lines %
ming/mim.py 1 75.89%
Totals Coverage Status
Change from base Build 99: 0.03%
Covered Lines: 5829
Relevant Lines: 6577

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants