Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency (@turf/boolean-disjoint) to @turf/boolean-valid #2094

Merged

Conversation

sipris
Copy link
Contributor

@sipris sipris commented Jun 15, 2021

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

@mfedderly
Copy link
Collaborator

We should merge this, but the PR is out of date and our CI system is currently not working. We probably need to fix CI, update this PR, and then merge it.

@sipris
Copy link
Contributor Author

sipris commented Jun 22, 2021

@mfedderly You can notify me when the CI is fixed, then I'll update the PR.

@mfedderly
Copy link
Collaborator

@rycgar seems like the CI is working again, looking forward to merging this when you get around to it.

@sipris sipris force-pushed the boolean-valid_missing-dep branch from 90ef5c6 to e3dd627 Compare June 23, 2021 12:37
@sipris
Copy link
Contributor Author

sipris commented Jun 23, 2021

@mfedderly here you go (y)

@mfedderly mfedderly merged commit dde1570 into Turfjs:master Jun 23, 2021
@mfedderly
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants