-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Mask module #2130
Rework Mask module #2130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Its a little weird that the meat of this lives in another repo. It introduces this issue where polygon-clipping depends on turf which depends on polygon-clipping, and that has the turf deps pinned at 5.x which is not great, but we already depended on this exactly polygon-clipping apparently so it isn't making things worse.
// basic x 4,627 ops/sec ±25.23% (21 runs sampled) | ||
// mask-outside x 3,892 ops/sec ±34.80% (15 runs sampled) | ||
// multi-polygon x 5,837 ops/sec ±3.03% (91 runs sampled) | ||
// overlapping x 22,326 ops/sec ±1.34% (90 runs sampled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 I AM SPEED
Huh this is actually just devDependencies so we're good. There was another package somewhere that had the old turf libraries as actual dependencies. |
@mfedderly Thanks, finally! Just wondering if there's going to be a an actual release anytime soon? |
I'm probably not going to get to it in the next few weeks but maybe @rowanwins has some time. |
This PR reworks the mask module to be much simpler.
It's a bit slower on some of the tests (like surprisingly so) although I haven't quite dug into why deeply, it's most likely something to do with the union operation being called when it probably doesn't need to be.This work was originally included in my v7 branch.
Resolves #1944
Resolves #1917
Resolves #2054
Resolves #1454
Before
After