Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line slice #417

Merged
merged 4 commits into from
Jun 17, 2016
Merged

Fix line slice #417

merged 4 commits into from
Jun 17, 2016

Conversation

camilleanne
Copy link
Contributor

Fixes #415 by removing a version of pointOnLine and requiring the module'd version of the function instead.

Also fixes a small bug in turf-point-on-line where the coordinates were not being set correctly if the object was a LineString instead of a complete Feature.

cc @morganherlocker

@morganherlocker
Copy link
Member

👍 Looks great

@morganherlocker
Copy link
Member

Added test case:

screenshot 2016-06-17 11 49 17

@morganherlocker morganherlocker merged commit 63d2ac1 into Turfjs:master Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use turf-point-on-line in turf-line-slice
2 participants
@camilleanne @morganherlocker