Support z-coordinate as input for @turf/turf-tin #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/turf-tin/bench.js
Outdated
|
|
||
| global.points = JSON.parse(fs.readFileSync(__dirname+'/test/Points.geojson')); | ||
| const points = JSON.parse(fs.readFileSync(__dirname+'/test/Points.json')); |
There was a problem hiding this comment.
When refactoring, use the path.join() method to make it friendly for cross platforms (Windows).
const path = require('path');
const points = JSON.parse(fs.readFileSync(path.join(__dirname, 'test', 'Points.json')));
packages/turf-tin/index.js
Outdated
| @@ -39,24 +39,42 @@ var featurecollection = helpers.featureCollection; | |||
| */ | |||
| module.exports = function (points, z) { | |||
| //break down points | |||
There was a problem hiding this comment.
We might want to add some simple validation to test the input is correctly a FeatureCollection.
if (points.type !== 'FeatureCollection') throw new Error('points must be a FeatureCollection');| if (z) point.z = p.properties[z]; | ||
| if (z) { | ||
| point.z = p.properties[z]; | ||
| } else if (p.geometry.coordinates.length === 3) { |
packages/turf-tin/test.js
Outdated
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const test = require('tape'); | ||
| const tin = require('./index.js'); |
There was a problem hiding this comment.
index.js can be dropped.
const tin = require('./');
packages/turf-tin/test.js
Outdated
|
|
||
| fs.writeFileSync(path.join(__dirname, 'test', 'Tin.json'), JSON.stringify(tinned)); |
There was a problem hiding this comment.
Saving the outputs is very useful to see the final results, also saving the fixtures using .geojson makes it easier to preview the GeoJSON directly in GitHub.
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #628 for
@turf/tin. PR has the following edits:test.jsandbench.jssyntax to ES6.Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.