Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module @turf/boolean-clockwise #789

Merged
merged 28 commits into from
Jun 18, 2017
Merged

New module @turf/boolean-clockwise #789

merged 28 commits into from
Jun 18, 2017

Conversation

stebogit
Copy link
Collaborator

@stebogit stebogit commented Jun 14, 2017

Brings @morganherlocker's initial work into a Turf mono repo.
Ref. #701 and #740

More tests probably needed.

stebogit and others added 15 commits June 1, 2017 08:42
Adds tests around 180th meridian to transformation modules
* replaced conrec with marchingsquare

* fixed script and tests

* updated bench

* updated readme

* updated package.json

* updated index.d.ts

* introduced suggested changes

* added zProperty to index.d.ts

* minor doc change

* Updates to Isolines
- Divide properties={} to two params
- Simplify Catch error logic (index.js)
- Update Typescript definition
- Add types.ts to test Typescript definition
- Add single task to benchmark
- Update Yarn.lock
- Simplify bench & test logic
- Save fixtures out to GeoJSON
CC: @stebogit

* perIsoline overlaps properties from toAllIsolines

* Update Readme
Buffer - Drop circle buffer operation
@stebogit
Copy link
Collaborator Author

Now that I read more carefully the original issue, a Polygon is not supposed to be accepted as input. I'll fix that.

@DenisCarriere DenisCarriere added this to the 4.5.0 milestone Jun 15, 2017
Fix for @turf/polygon-tangents - Resolves #785
Adds mask option to `@turf/point-grid`
@DenisCarriere
Copy link
Member

Strange, unkink-polygon is failing... strange

Copy link
Member

@DenisCarriere DenisCarriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DenisCarriere DenisCarriere merged commit f40b3d1 into booleans Jun 18, 2017
@DenisCarriere
Copy link
Member

Ops... this PR got merged into the boolean branch, this should be in the master branch.

@stebogit
Copy link
Collaborator Author

stebogit commented Jun 18, 2017

I thought for some reason you wanted to keep all the booleans together... 😅

@DenisCarriere
Copy link
Member

Added @morganherlocker to assignee (not requesting anything), just a way to track who did what when we push releases.

@DenisCarriere
Copy link
Member

@stebogit Humm.. no that was @rowanwins who decided to group 8 modules into one branch/PR.

Once a module is 100% good to go, we should simply merge it to the master branch, all other branches are just "temp" or "work in progress".

@DenisCarriere
Copy link
Member

@rowanwins has been (just recently) creating new PR's for each of those boolean modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants