Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the update_ref! API #85

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Update the update_ref! API #85

merged 10 commits into from
Oct 23, 2023

Conversation

FredericWantiez
Copy link
Member

@FredericWantiez FredericWantiez commented Oct 22, 2023

@yebai as discussed, update_ref!(ref, pc) should instead be something like this update_ref!(ref, pc, sampler) so that we can dispatch properly on the sampler type.

With this, we can clean up the SSM example in the doc and remove the remaining Libtask references and compare PG and PGAS on an AbstractStateSpaceModel

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023

Pull Request Test Coverage Report for Build 6615226923

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 95.864%

Totals Coverage Status
Change from base Build 6496492859: 0.3%
Covered Lines: 394
Relevant Lines: 411

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bacdaf) 95.60% compared to head (78112ca) 95.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   95.60%   95.86%   +0.25%     
==========================================
  Files           8        8              
  Lines         410      411       +1     
==========================================
+ Hits          392      394       +2     
+ Misses         18       17       -1     
Files Coverage Δ
ext/AdvancedPSLibtaskExt.jl 92.77% <100.00%> (ø)
src/AdvancedPS.jl 33.33% <ø> (ø)
src/container.jl 100.00% <100.00%> (+0.78%) ⬆️
src/pgas.jl 96.29% <100.00%> (ø)
src/smc.jl 97.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @FredericWantiez -- it looks good to me. See a few minor comments below.

src/container.jl Outdated Show resolved Hide resolved
src/container.jl Outdated Show resolved Hide resolved
@@ -91,39 +90,35 @@ plot(x; label="x", xlabel="t")
plot(y; label="y", xlabel="t")

# Each model takes an `AbstractRNG` as input and generates the logpdf of the current transition:
mutable struct NonLinearTimeSeries <: AdvancedPS.AbstractGenericModel
X::Array
mutable struct NonLinearTimeSeries <: AdvancedPS.AbstractStateSpaceModel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider adding SSMProblems to the dependency and follow its interface. We can also remove the out-of-date SSM interface from AdvancedPS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but maybe in another PR ? I think there's some work needed around the way we handle the observations/data here compared to SSMProblems

* Update smc.jl

* Update smc.jl
@yebai yebai marked this pull request as ready for review October 23, 2023 14:54
src/container.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/container.jl Outdated Show resolved Hide resolved
src/AdvancedPS.jl Show resolved Hide resolved
src/container.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/container.jl Outdated Show resolved Hide resolved
src/container.jl Outdated Show resolved Hide resolved
@yebai yebai merged commit 67d3496 into master Oct 23, 2023
15 of 20 checks passed
@yebai yebai deleted the fred/ancestor branch October 23, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants