Update the update_ref! API
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6615226923
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 95.60% 95.86% +0.25%
==========================================
Files 8 8
Lines 410 411 +1
==========================================
+ Hits 392 394 +2
+ Misses 18 17 -1
☔ View full report in Codecov by Sentry. |
yebai
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Thanks, @FredericWantiez -- it looks good to me. See a few minor comments below.
| @@ -91,39 +90,35 @@ plot(x; label="x", xlabel="t") | |||
| plot(y; label="y", xlabel="t") | |||
|
|
|||
| # Each model takes an `AbstractRNG` as input and generates the logpdf of the current transition: | |||
| mutable struct NonLinearTimeSeries <: AdvancedPS.AbstractGenericModel | |||
| X::Array | |||
| mutable struct NonLinearTimeSeries <: AdvancedPS.AbstractStateSpaceModel | |||
There was a problem hiding this comment.
Let's consider adding SSMProblems to the dependency and follow its interface. We can also remove the out-of-date SSM interface from AdvancedPS.
There was a problem hiding this comment.
Agree, but maybe in another PR ? I think there's some work needed around the way we handle the observations/data here compared to SSMProblems
* Update smc.jl * Update smc.jl
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yebai
reviewed
Oct 23, 2023
yebai
reviewed
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yebai as discussed,
update_ref!(ref, pc)should instead be something like thisupdate_ref!(ref, pc, sampler)so that we can dispatch properly on the sampler type.With this, we can clean up the SSM example in the doc and remove the remaining
Libtaskreferences and comparePGandPGASon anAbstractStateSpaceModel