Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper type dispatch #91

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Proper type dispatch #91

merged 2 commits into from
Nov 4, 2023

Conversation

FredericWantiez
Copy link
Member

@FredericWantiez FredericWantiez commented Nov 4, 2023

Turing uses its own Sampler type that subtypes AbstractMCMC.AbstractSampler, we can't really impose AbstractParticleSampler outside of AdvancedPS.

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Pull Request Test Coverage Report for Build 6757184921

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.098%

Totals Coverage Status
Change from base Build 6750472565: 0.0%
Covered Lines: 394
Relevant Lines: 410

💛 - Coveralls

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3700563) 96.09% compared to head (2b83f7f) 96.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files           8        8           
  Lines         410      410           
=======================================
  Hits          394      394           
  Misses         16       16           
Files Coverage Δ
src/container.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FredericWantiez FredericWantiez marked this pull request as ready for review November 4, 2023 13:46
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- can you also bump the version and make a release?

@yebai yebai merged commit 8fbcb20 into master Nov 4, 2023
14 of 19 checks passed
@yebai yebai deleted the fred/fix_sampler_type branch November 4, 2023 21:19
@FredericWantiez
Copy link
Member Author

You're so fast ! Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants