-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic rewrite of the package 2023 edition Part II: Location-scale variational families #51
Basic rewrite of the package 2023 edition Part II: Location-scale variational families #51
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 81.15% 85.92% +4.77%
==========================================
Files 10 11 +1
Lines 138 199 +61
==========================================
+ Hits 112 171 +59
- Misses 26 28 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Red-Portal -- it looks good overall. I have a few minor comments below.
test/interface/location_scale.jl
Outdated
z = rand(q) | ||
@test eltype(z) == realtype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit redundant with above logpdf
tests.
z = rand(q) | |
@test eltype(z) == realtype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yebai Though without it, it seems codecov
complanes that _logpdf
is not covered. Should I still remove the tests fore _logpdf
?
This is a partial pull request of #45.
(The original PR is now severely outdated.)
The content of Part II is as follows: