Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonpath): Properly handle len of object in array, len of int and len of bool #372

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Nov 19, 2022

Summary

Fixes #371
Fixes #370

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@TwiN TwiN added the bug Something isn't working label Nov 19, 2022
@TwiN TwiN marked this pull request as ready for review November 19, 2022 21:57
@codecov-commenter
Copy link

Codecov Report

Base: 81.88% // Head: 81.92% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (dc080ef) compared to base (e9f46c5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   81.88%   81.92%   +0.04%     
==========================================
  Files          54       54              
  Lines        4047     4056       +9     
==========================================
+ Hits         3314     3323       +9     
  Misses        576      576              
  Partials      157      157              
Impacted Files Coverage Δ
jsonpath/jsonpath.go 92.78% <100.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN merged commit 4f569b7 into master Nov 19, 2022
@TwiN TwiN deleted the fix/jsonpath branch November 20, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

len function does not behave as intended for JSON arrays, integers and booleans
2 participants