Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Default Alert.Enabled to true #380

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Dec 6, 2022

Summary

BREAKING CHANGE: It used to default to false, which meant that users had to explicitly set endpoints[].alerts[].enabled to true

Discussion #374

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

BREAKING CHANGE: It used to default to false, which meant that users had to explicitly set endpoints[].alerts[].enabled to true
@TwiN TwiN added bug Something isn't working area/alerting Related to alerting labels Dec 6, 2022
@TwiN TwiN marked this pull request as ready for review December 6, 2022 04:12
@TwiN TwiN merged commit d058d7a into master Dec 6, 2022
@TwiN TwiN deleted the fix/alert-default-enabled-true branch December 6, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant