Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Enforce mandatory space around condition operator #382

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Dec 6, 2022

Summary

BREAKING CHANGE: The comparator in each condition must now be wrapped by a space (e.g. [STATUS] == 200) or the condition will not be valid.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

BREAKING CHANGE: The comparator in each condition must now be wrapped by a space (e.g. [STATUS] == 200) or the condition will not be valid.
@TwiN TwiN marked this pull request as ready for review December 6, 2022 06:28
@TwiN TwiN added the bug Something isn't working label Dec 6, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 82.00% // Head: 82.04% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (b431887) compared to base (741109f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   82.00%   82.04%   +0.03%     
==========================================
  Files          54       54              
  Lines        4056     4065       +9     
==========================================
+ Hits         3326     3335       +9     
  Misses        574      574              
  Partials      156      156              
Impacted Files Coverage Δ
core/condition.go 98.01% <100.00%> (+0.07%) ⬆️
core/endpoint.go 74.78% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN merged commit 2346a6e into master Dec 6, 2022
@TwiN TwiN deleted the fix/mandatory-condition-operator-spaces branch December 6, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants