Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modify implementation of TLS #457

Merged
merged 2 commits into from
Apr 22, 2023
Merged

refactor: Modify implementation of TLS #457

merged 2 commits into from
Apr 22, 2023

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Apr 22, 2023

Summary

This PR modifies the implementation of TLS, which was originally implemented in #322

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@chr1st1ank if you could test it on your end, I would appreciate it (just to make sure I didn't accidentally break anything 😂), but no pressure.

@TwiN TwiN merged commit 83edca6 into master Apr 22, 2023
@TwiN TwiN deleted the refactor/tls branch April 22, 2023 19:22
@chr1st1ank
Copy link
Contributor

@TwiN , yes I tested the new version locally and it works perfectly with the same config and certificates as before.
Nice move mit the omitempty for the whole TLSConfig object. That makes the error handling easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants