fix(panic): fix panic when censoring utf-8 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stephenduke-care <stephen.duke@care.com>
Signed-off-by: stephenduke-care <stephen.duke@care.com>
This was referenced Sep 11, 2023
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
===========================================
+ Coverage 99.47% 100.00% +0.52%
===========================================
Files 1 1
Lines 191 191
===========================================
+ Hits 190 191 +1
+ Misses 1 0 -1
☔ View full report in Codecov by Sentry. |
|
This is great, @TwiN what needs to be done to get this merged in? |
TwiN
approved these changes
Sep 21, 2023
|
@shinroo Sorry about the delay! |
No worries, thanks for the quick action. Great library you've got here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#43
Modified indexToRune to correctly count runes up to the given byte index. Adjusted Censor function to handle multi-byte characters properly, ensuring accurate index calculations during the censoring process. Updated incrementation of currentIndex to consider byte length, facilitating correct string iteration.
Checklist
Tested and/or added tests to validate that the changes work as intended, if applicable.
Updated documentation in README.md, if applicable.